Default to standard retry #3236
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Detected 1 possible performance regressions:
|
Co-authored-by: Juli Tera <57973151+jterapin@users.noreply.github.com>
jterapin
approved these changes
Jul 16, 2025
gems/aws-sdk-dynamodb/lib/aws-sdk-dynamodb/plugins/extended_retries.rb
Outdated
Show resolved
Hide resolved
|
|
||
| option( | ||
| :max_attempts, | ||
| default: 10, |
There was a problem hiding this comment.
Was there a reason why it was 10 attempts? I was curious
There was a problem hiding this comment.
I'm not certain. Probably because of throttling and can be loss of data.
gems/aws-sdk-dynamodb/lib/aws-sdk-dynamodb/plugins/extended_retries.rb
Outdated
Show resolved
Hide resolved
Co-authored-by: Juli Tera <57973151+jterapin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default retry strategy to standard.
This is a mild breaking change, rendering some config values useless (since standard doesn't have too many configurable options).
DynamoDB extended retries will include a new default of 10 retries but no configurable jitter/backoff policy unless configured back to legacy.
Other changes to the retry plugin are rubocop related.
For any disruptions (to anyone viewing this PR) please set your mode with
Aws.config[:retry_mode] = 'legacy'